-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle new unexpected_cfgs
warnings
#3022
Conversation
You can use the |
Thanks Ed, I'll give that a try. |
Weirdly this causes an entirely different warning. No idea why this is coming from the build script.
|
So I was able to keep this for most of the crates and further refine code gen to elide code that depended on excluded features, which is great. 🎉 I still have to allow the warning for the |
Looks like the error is coming from the |
This allows to find solutions to the false positives that were found in the ecosystem before turning it to `warn` by default again. Most projects hit by this seem to just disable the warning, which indicates that it isn't working as expected. CC rust-lang#124800 CC rust-lang#124804 CC rust-lang#124821 CC hyperium/hyper#3660 CC microsoft/windows-rs#3022 CC rust-bitcoin/rust-bitcoin#2748 CC tokio-rs/tokio#6538
Much like tokio-rs/tokio#6538 I need to silence the new warnings introduced by rust-lang/cargo#13571 about unexpected
cfg
condition names because the alternative is to use a build script which is undesirable and impractical as that introduces a warning about a build script syntax that isn't compatible with the MSRV.I was able to keep this for most of the crates and further refine code gen to elide code that depended on excluded features.